-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Fix some mistakes #10711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some mistakes #10711
Conversation
1956d54
to
bf965dc
Compare
@@ -6,7 +6,7 @@ How to Work with Lifecycle Callbacks | |||
|
|||
Sometimes, you need to perform an action right before or after an entity | |||
is inserted, updated, or deleted. These types of actions are known as "lifecycle" | |||
callbacks, as they're callback methods that you need to execute during different | |||
callbacks, as they're callback functions that you need to execute during different |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the example given after the text it is method
and not functions
.
@@ -7,26 +7,26 @@ on your object. If you're using validation with forms, this means that you | |||
can make these custom errors display next to a specific field, instead of | |||
simply at the top of your form. | |||
|
|||
This process works by specifying one or more *callback* methods, each of | |||
which will be called during the validation process. Each of those methods | |||
This process works by specifying one or more *callback* functions, each of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, I think this all was fine and that method
should stay
@@ -88,10 +88,10 @@ Configuration | |||
} | |||
} | |||
The Callback Method | |||
------------------- | |||
The Callback Function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here, its method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few minor comments, looks good!
hi @kunicmarko20, thanks for review. |
This is the example I was talking about, so So you would say if it was like I disagree with this but I am not a decider, will leave it to the symfony docs team. btw, thank you for the contribution! 😄 |
@@ -142,7 +142,7 @@ With this configuration, there are three validation groups: | |||
``registration`` | |||
Contains the constraints on the ``email`` and ``password`` fields only. | |||
|
|||
Constraints in the ``Default`` group of a class are the constraints that have | |||
Constraints in the ``User`` group of a class are the constraints that have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @OskarStark
// User class
/** @Asert\NotBlanc(groups={"User"}) */
this constraint is not added to the Default
group, so
... or that are configured to a group equal to the class name ...
is valide only for User
and not for Default
group.
@@ -1945,7 +1945,7 @@ the ``dev`` environment). | |||
given the adapter they are based on. Internally, a pool wraps the definition | |||
of an adapter. | |||
|
|||
.. _reference-cache-systen: | |||
.. _reference-cache-system: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, but shouldn’t this produce an error by Sphinx on build ?
90f5455
to
c545e17
Compare
I rebased the branch and changed thre PR base to 3.4. |
@ottaviano thanks for this contribution! Sadly this PR contains too many changes: some are obvious, others have been challenged by reviewers and others don't look right (like the form help related changes, which were introduced in 4.x, not 3.4). So, I've created #11109 with the obvious fixes you did here and we can create in the future other PRs to change other things. Thank you! |
No description provided.